Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the rejected promises part of no-throw to new rule no-reject #118

Merged
merged 5 commits into from
Feb 19, 2019

Conversation

jonaskello
Copy link
Owner

This bascially moves #116 to a new rule called no-reject. See this comment for the background.

Fixes #115.

@codecov
Copy link

codecov bot commented Feb 18, 2019

Codecov Report

Merging #118 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #118   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     16    +1     
  Lines         360    364    +4     
  Branches      152    153    +1     
=====================================
+ Hits          360    364    +4
Impacted Files Coverage Δ
src/noThrowRule.ts 100% <100%> (ø) ⬆️
src/noRejectRule.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f40c59f...fd8aedd. Read the comment docs.

@jonaskello
Copy link
Owner Author

Released in 5.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant